refactor(reticle): rename Reticle to ReticleLogo, add reticle swap prop - #31
Merged
Conversation
…prop
Reticle is renamed to ReticleLogo (file and component) to read clearly
alongside ReticleDial. Every hero gets a `reticle` prop ('dial' | 'logo')
to pick which atom renders, replacing the earlier hardcoded per-hero
choice; /design opts into 'logo', the rest default to 'dial'.
Also fixes the work-detail hero's client-logo overlay: it now renders
inside Tile itself (a new optional `logo` prop) so the logo fade-out and
image fade-in share the same hover group, instead of two mismatched
hover boundaries (the outer stage box vs the image itself).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reticlerenamed toReticleLogo(file + component), so it reads clearly next toReticleDial.reticleprop ('dial' | 'logo') instead of hardcoding which atom renders;/designopts into'logo', the rest default to'dial'.Tileitself (new optionallogoprop), so the logo fade-out and image fade-in share one hover boundary instead of two mismatched ones.Test plan
pnpm lint:check/pnpm type:checkcleanpnpm buildsucceeds (ran via pre-push hook)