Add memory gating to query2 - #14
Merged
Merged
Conversation
d-callan
commented
Aug 22, 2026
d-callan
commented
Contributor
- Add --memory-budget CLI param (MB, 0=no limit)
- Implement memory_semaphore with RAII sem_guard for exception-safe gating
- Estimate per-sub-index memory as heap peak + mmap working set:
- Heap: max(phase1=smers+responses, phase2=agg with positions/ratios/counts)
- Mmap: bloom_size (no --fast) or index_size (--fast, all partitions resident)
- Compressed indexes: bloom_size * nb_partitions with --fast (decompressed to heap)
- Sort sub-indexes by descending memory
- Gate task execution via semaphore acquire/release
- Warn when an index exceeds budget (runs alone)
- Add 5 tests: baseline, tight budget, --fast+budget, position format+budget, oversized index warning
- Add --memory-budget CLI param (MB, 0=no limit) - Implement memory_semaphore with RAII sem_guard for exception-safe gating - Estimate per-sub-index memory as heap peak + mmap working set: - Heap: max(phase1=smers+responses, phase2=agg with positions/ratios/counts) - Mmap: bloom_size (no --fast) or index_size (--fast, all partitions resident) - Compressed indexes: bloom_size * nb_partitions with --fast (decompressed to heap) - Sort sub-indexes by descending memory for optimal packing - Gate task execution via semaphore acquire/release - Warn when an index exceeds budget (runs alone) - Add 5 tests: baseline, tight budget, --fast+budget, position format+budget, oversized index warning
Resolve conflicts in query2.cpp (multi-path logging) and CMakeLists.txt (keep both test registrations). Add test for multi-index paths + memory budget together.
Owner
|
@d-callan Can you test this branch on TACC? Or do you need a tagged release? |
Contributor
Author
|
depends what were testing for.. dont think we need tacc / formal release to know 'it wont break' but to test perf via tacc in galaxy context i need a release |
Contributor
Author
|
(thanks for having another look, fixing it up etc) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.