Skip to content

Fix console crash on macOS #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmontaigu merged 1 commit into from
Sep 22, 2026
+13 −8
Merged

Fix console crash on macOS #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/Runtime/Consoles.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#ifndef PYTHON_PLUGIN_CONSOLES_H
#define PYTHON_PLUGIN_CONSOLES_H

#include <QBrush>
#include <QListWidget>
#include <QString>

Expand Down Expand Up @@ -107,27 +108,30 @@ class ccConsoleOutput

private:
const QString m_prefix;
ConsoleWrapper m_output{[this](const QString &message)
/// The callback must capture the values it needs, not "this":
/// because instances of this class are moved by pybind11...
ConsoleWrapper m_output{[prefix = m_prefix](const QString &message)
{
if (m_prefix.isEmpty())
if (prefix.isEmpty())
{
ccLog::Print(message);
}
else
{
ccLog::Print(m_prefix + message);
ccLog::Print(prefix + message);
}
}};
};

/// Writes messages to the QListWidget given
///
class ListWidgetConsole
{
public:
ListWidgetConsole(QListWidget *view, const Qt::GlobalColor color) : m_view(view), m_brush(color)
{
}
ListWidgetConsole(QListWidget *view, const QColor &color) : m_view(view), m_brush() {}
ListWidgetConsole(QListWidget *view, const QColor &color) : m_view(view), m_brush(color) {}
explicit ListWidgetConsole(QListWidget *view) : m_view(view), m_brush() {}

void write(const char *messagePart)
Expand All @@ -147,12 +151,13 @@ class ListWidgetConsole
private:
QListWidget *m_view;
QBrush m_brush;
QString m_prefix;
ConsoleWrapper m_output{[this](const QString &message)
/// callback must capture the values it needs, not "this".
/// because instances of this class are moved by pybind11...
ConsoleWrapper m_output{[view = m_view, brush = m_brush](const QString &message)
{
auto *messageItem = new QListWidgetItem(message);
messageItem->setForeground(m_brush);
m_view->addItem(messageItem);
messageItem->setForeground(brush);
view->addItem(messageItem);
}};
};
#endif // PYTHON_PLUGIN_CONSOLES_H
Loading