Repository navigation
Remove CCShareable / + associated custom holders in favor of std::shared_ptr - #184
Merged
Merged
Conversation
Owner
|
Ah nice to see that the CCShareable is gone and that the inheritance of std::vector is considered to be removed, these were some refactors I was tempted to do, but did not know If they would have been accepted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CloudCompare/CloudCompare#2426 removed CCShareable mechanism (in favor of std::shared_ptr) and this PR try to put CC-PythonRuntime in sync with this change.
observer_ptrstay because we have to cure the root of evil first (inheritance on std::vector vs. composition) ;).Sorry for the formatting noise on stubs.