Merged
Conversation
libtmux 0.55.1 ships the pytest-plugin socket-reaper fix (tmux-python/libtmux#661) so the `server` / `TestServer` fixtures now kill the tmux daemon AND unlink the socket file under `/tmp/tmux-<uid>/` on teardown. This bumps the runtime floor and refreshes uv.lock so CI and fresh installs pick up the fix. Verified locally: after the bump, `uv run pytest` leaves a single residual socket per run (down from thousands accumulating across runs pre-fix). The remaining straggler originates outside the standard fixture teardown path and is a separate, minor issue — not a regression. Supersedes the local conftest reaper proposed in #23; that PR can now be closed without merge.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
- Coverage 87.01% 86.78% -0.24%
==========================================
Files 38 38
Lines 1710 1710
Branches 201 201
==========================================
- Hits 1488 1484 -4
- Misses 164 167 +3
- Partials 58 59 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump the runtime floor of
libtmuxfrom>=0.55.0to>=0.55.1and refreshuv.lockto install 0.55.1.libtmux 0.55.1 ships the pytest-plugin socket-reaper fix (tmux-python/libtmux#661): the
serverandTestServerfixtures now kill the tmux daemon AND unlink the socket file under/tmp/tmux-<uid>/on teardown. That's the upstream root-cause fix for the test-socket leak reported in #20.Effect on open PRs
Supersedes #23 (local conftest reaper). The local reaper was a downstream workaround for the same issue #661 fixes upstream. Once this bump lands, PR #23's fixture adds no behavior beyond what libtmux already does on teardown — it becomes pure churn. Recommend closing #23 without merge.
Unaffected: #21 (async channel waits), #22 (is_caller socket scope). Both are libtmux-mcp-only bugs with no upstream analog.
Test plan
uv run ruff check . --fix --show-fixesuv run ruff format .uv run mypyuv run py.test --reruns 0 -vvv(363 passed)just build-docsEnd-to-end verification: after the bump, a clean
uv run pytestfrom an empty/tmp/tmux-<uid>/libtmux_test*state leaves 1 residual socket (down from thousands accumulating across runs pre-fix). The lone straggler originates outside the standard fixture teardown path — a separate, minor issue, tracked separately if it matters.Companion PRs
asyncio.to_thread#21 — event-loop block in channel waits (closes wait_for_channel and signal_channel block the FastMCP event loop (sync subprocess.run) #18, unaffected)is_callersocket-blind false positive (closes is_caller annotation gives false positives across tmux sockets #19, unaffected)test(conftest): reap leaked libtmux_test* sockets after session #23— local reaper (closes list_servers exposes dozens of leaked libtmux_test* tmux daemons after test runs #20) — superseded by this PR, close without merge