throw when cert is null#397
Closed
mattkrick wants to merge 1 commit into
Closed
Conversation
Author
|
@tngan any update here? anything i can do to get this into master? |
sultanhq
pushed a commit
to findmypast/samlify
that referenced
this pull request
Apr 30, 2025
fix: throw when cert is null tngan#397 Co-authored-by: rassul-findmypast <rassul-findmypast@users.noreply.github.com> Co-authored-by: JAParsons <johnparsons932@gmail.com> Co-authored-by: Jonathan Darrer <jdarrer@findmypast.com> Co-authored-by: Matt Krick <matt.krick@gmail.com>
Owner
|
Thank you for this fix, @mattkrick, and sorry for the long delay. The null-cert handling here has been incorporated via #565, which explicitly carries this change forward. Closing as superseded — much appreciated for the contribution and your support! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #222
I had a case where our saved IdP cert was invalid & when the correct cert came back in the response the cert was null.
The error message received was
Cannot read property 'map' of null, which wasn't helpful.This throws an error message which is a bit more helpful.