fix(web): declare the Privacy/Terms build args in web/Dockerfile - #1053
Merged
Merged
Conversation
#1051 read NEXT_PUBLIC_PRIVACY_URL and NEXT_PUBLIC_TERMS_URL in site.ts but never declared them in web/Dockerfile, so `docker build` dropped the hosted deployment's values and 1.12.0 shipped without the footer links or the consent line. Adds the ARG/ENV pair and a comment explaining why the Dockerfile is the allowlist. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1051 added
NEXT_PUBLIC_PRIVACY_URL/NEXT_PUBLIC_TERMS_URLtoweb/src/lib/site.tsbut not toweb/Dockerfile, whose explicitARG/ENVlist is what lets aNEXT_PUBLIC_*value reachnext build.docker buildonly warns about an unconsumed--build-arg, so the hosted 1.12.0 image built green with the links absent.This adds the two declarations (empty defaults, so the published OSS image stays generic) and a comment stating the rule: every
NEXT_PUBLIC_*read insite.tsmust be declared here.Verified locally that every
process.env.NEXT_PUBLIC_*referenced bysite.tsnow has anARGline.🤖 Generated with Claude Code