Conversation
The TS and Python SDK READMEs' "Trash and restore" sections covered agent- and message-level trash but never mentioned that account.delete() / client.account.delete() also moved to trash-by-default with a permanent option, even though the client code, both CHANGELOGs, docs/api.md, and cli/README.md already describe it (#1043). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0189GPbGfEfVLoV2Jh4v9KQN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sdks/typescript/README.mdandsdks/python/README.md: the "Trash and restore" sections documented agent- and message-level trash but never mentioned thataccount.delete()/client.account.delete()also moves the account to the trash by default (with apermanentoption for the old immediate-erase behavior), even though this is already implemented and documented everywhere else — both SDKs'CHANGELOG.md(## Unreleased→### Breaking), thedelete()docstrings/JSDoc insdks/typescript/src/v1/client.tsandsdks/python/src/e2a/v1/client.py,docs/api.md, rootREADME.md, andcli/README.md(from feat(account): 30-day soft deletion, identity tombstones, abuse-evidence summaries #1043, "30-day soft deletion, identity tombstones, abuse-evidence summaries"). Added a matching paragraph + example to each README's "Trash and restore" section, mirroring the existing wording/tone used for agent- and message-level trash.Per step 0 of this run's audit, I checked for prior unmerged doc work first: open PR #1037 already covers the protection-config JSON schema example and the AGENTS.md
delegatedpackage mention, and several stale unmergedclaude/relaxed-cerf-*branches already attempted (now-outdated) MCP tool-count fixes and other items — none of that is touched here to avoid duplicating it. This PR covers a new, verified gap not addressed by any of that prior work.Test plan
client.ts/client.pydelete()implementations, bothCHANGELOG.mdfiles,docs/api.md,cli/README.md) rather than run — no build/test surface affected.🤖 Generated with Claude Code
https://claude.ai/code/session_0189GPbGfEfVLoV2Jh4v9KQN
Generated by Claude Code