Add explicit shared-pool runner registration and reconciliation - #107
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A shared host's reconnect inventory can span multiple workspaces, but the existing registration and reconciliation APIs require one workspace. Add explicit pool-scoped entry points that use authoritative assigned rows for each tenant while preserving legacy workspace validation.
Unknown claims are destroy candidates rather than cross-workspace adoptions. Ambiguous assigned session IDs fail before session mutations. Runner generation and capacity checks are retained; the wire protocol and control.Fleet interface do not change. Runner connections and replacement locks are keyed by pool plus runner name, preventing a same-named host in another pool from receiving commands or evicting the connection. Hosted adapters must authenticate pool-wide authority before calling the new methods.
Validation: controlapp and runnerplane race suites, vet, and all command builds pass. The cloud integration passed a separate-process CLI/gateway test with real PostgreSQL and rendered runtime grants, covering two workspaces, bootstrap replay refusal, legacy/foreign refusal, reconnect and live revocation. Local full OSS verification was attempted; Docker Hub connectivity failed and an existing latency cleanup test timed out under suite load. The latest GitHub verify check passed. Independent and adversarial reviews passed after fixing the cross-pool runner-name collision, with outbound routing and retirement regressions.
This is a prerequisite for Phase A shared-host qualification, not a hardware or production qualification result.