Require signaling privileges for non-root microVM teardown - #108
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A non-root runner manages VMMs under distinct UIDs and needs
CAP_KILLto signal and tear them down. Startup now refuses hosts missing that capability; tests and the documented privilege contract include it. The opt-in KVM harness can target an existing delegated service cgroup for real non-root qualification.Validation: Linux capability checks and missing-capability cases pass; the full real KVM contract passes as the non-root runner (12 cases, zero skips). Six real shared-workspace cold cycles and normal CLI teardown also pass with the final patched jailer. Five supplemental lifecycle probes ran the entire driver-level harness as root and are explicitly separated from non-root evidence. Portable tests and vet pass with Docker unavailable; code CI verify passes. Independent and adversarial code reviews passed, with documentation corrections included; all final-head CI checks pass.
Companion cloud PR: https://github.com/tokencanopy/rainier-cloud/pull/141. Phase A feasibility is complete and disposable infrastructure is removed. Runner-restart recovery and production/load/economic qualification remain later gates.