Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
The reconnect authorization foundation defines the signed transcript and durable authority, but consumers have no shared session-RPC request/response contract. Gateway-local schemas would let hosted and self-hosted implementations drift.
Define shared enroll/begin/accept method names, typed payloads and strict decoders for requests and cryptographic responses. Decoders enforce a 4096-byte raw payload limit, exact fields, canonical encodings, fixed errors and zero values on refusal. Enrollment retains the existing environment response so successful key enrollment does not break initial secret delivery. Document original-socket authority, runner-only begin/accept routing, commit-before-response and relay fencing requirements.
No handlers, capabilities or guest reconnect behavior are enabled. Gateway/guest integration, cold-resume ordering and hardware qualification remain follow-up work.
Validation
21efedb:make verify, non-root jail ownership regression, CLI/client race checks and fleet script syntax. Run evidence.make verifyencountered the existing latency cleanup timeout (passed in isolation) and remained in Docker-backed tests; the redundant run was stopped after Linux CI passed.This is a protocol library change. The executable challenge/sign/decode/verify example is the real-execution check; there is no newly enabled service endpoint to exercise.