Open
Conversation
liquo-rice
reviewed
Apr 23, 2026
Comment on lines
+13
to
+14
| if index_s == len(s): | ||
| return True |
There was a problem hiding this comment.
これは、index_sをインクリメントした時以外は判定不要なので、上のifの中に入れた方が良さそうです。
| index_s += 1 | ||
| if index_s == len(s): | ||
| return True | ||
| index_t += 1 |
There was a problem hiding this comment.
毎回のiterationで、+1するので、forループで書き換えた方が良さそうです。
Owner
Author
There was a problem hiding this comment.
なるほど、どちらもご指摘の通りです。自分でも見直してこうした点に気づけるようになりたいです。
|
|
||
| index_s = 0 | ||
| index_t = 0 | ||
| while len(s) - index_s <= len(t) - index_t: |
There was a problem hiding this comment.
制約を見ると、sは短めなので、early returnするメリットはあまりないかもしれませんね。
0 <= s.length <= 100
0 <= t.length <= 104
Owner
Author
There was a problem hiding this comment.
速度を簡単に測ってみましたが大きな差はなく sol3.pyの方が遅い場合もありました。
高速化したつもりがそうなっていない場合もあるんですね。
sol1: 1532.053 ms
sol3: 1710.168 ms
(sol3 / sol1: 1.116)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/is-subsequence/