Fix print ignoring user dither/threshold/density settings#25
Merged
Conversation
The print-settings flyout writes density, dither mode, and threshold to the editor store's printSettings, but print() read them from the separate printer store, which those edits never reach. As a result prints always used the defaults (floyd-steinberg, threshold 128, density 2) regardless of what the user selected. Read density/dither/threshold and paperType from the editor store — the same source the flyout writes to — so prints honor the chosen settings.
verglor
force-pushed
the
fix/ignored-settings
branch
from
d7c6ac9 to
1938f60
Compare
Owner
|
Thanks for the contribution. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The print-settings flyout writes density, dither mode, and threshold to the editor store's printSettings, but print() read them from the separate printer store, which those edits never reach. As a result prints always used the defaults (floyd-steinberg, threshold 128, density 2) regardless of what the user selected.
Read density/dither/threshold and paperType from the editor store — the same source the flyout writes to — so prints honor the chosen settings.
Also fixes #22.