Skip to content

fix: support action module #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbinna merged 1 commit into from
Jan 7, 2026
Merged

fix: support action module #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 70 additions & 5 deletions packages/nx-forge/src/shared/manifest/util-manifest.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ import { HostedResourcesSchema } from '@forge/manifest/out/schema/manifest';
* https://developer.atlassian.com/platform/forge/apis-reference/ui-api-bridge/modal/)
* - Resource 4: Custom UI resource associated with a Jira custom field module
* - Resource 5: UI Kit resource associated with a Jira custom field module
* - Resource 6: UI Kit resource associated with an automation action module
* - Resource 7: Custom UI resource associated with an automation action module
* - Resource static: Static resource referencing a folder, as used in Rovo agents
* to reference file directories.
*/
Expand All @@ -31,7 +33,7 @@ describe('util-manifest', () => {
},
}));

const resources = makeUIResources(6);
const resources = makeUIResources(8);
const staticResource: HostedResourcesSchema = {
key: 'static-resource',
path: 'not/a/project/ref',
Expand Down Expand Up @@ -84,6 +86,45 @@ describe('util-manifest', () => {
edit: { resource: resources[5].key, render: 'native' },
},
],
action: [
{
key: 'action-1',
function: 'dummy-function',
name: 'action 1',
actionVerb: 'CREATE',
description: 'action 1 description',
config: {
render: 'native',
resource: resources[6].key,
},
inputs: {
input1: {
title: 'input 1',
type: 'string',
required: true,
description: 'input 1 description',
},
},
},
{
key: 'action-2',
function: 'dummy-function',
name: 'action 2',
actionVerb: 'CREATE',
description: 'action 2 description',
config: {
resource: resources[7].key,
},
inputs: {
input1: {
title: 'input 1',
type: 'string',
required: true,
description: 'input 1 description',
},
},
},
],
'rovo:agent': [
{
key: 'fake-agent',
Expand Down Expand Up @@ -116,6 +157,12 @@ describe('util-manifest', () => {
expect(
resourceTypeByResourceDefinition(manifest)(resources[5])
).toStrictEqual('ui-kit');
expect(
resourceTypeByResourceDefinition(manifest)(resources[6])
).toStrictEqual('ui-kit');
expect(
resourceTypeByResourceDefinition(manifest)(resources[7])
).toStrictEqual('custom-ui');
expect(
resourceTypeByResourceDefinition(manifest)(staticResource)
).toStrictEqual('static');
Expand Down Expand Up @@ -143,6 +190,12 @@ describe('util-manifest', () => {
expect(
isResourceType(manifest, acceptedResourceTypes)(resources[5])
).toStrictEqual(true);
expect(
isResourceType(manifest, acceptedResourceTypes)(resources[6])
).toStrictEqual(true);
expect(
isResourceType(manifest, acceptedResourceTypes)(resources[7])
).toStrictEqual(true);
expect(
isResourceType(manifest, acceptedResourceTypes)(staticResource)
).toStrictEqual(false);
Expand All @@ -167,6 +220,12 @@ describe('util-manifest', () => {
expect(
isResourceType(manifest, acceptedResourceTypes)(resources[5])
).toStrictEqual(false);
expect(
isResourceType(manifest, acceptedResourceTypes)(resources[6])
).toStrictEqual(false);
expect(
isResourceType(manifest, acceptedResourceTypes)(resources[7])
).toStrictEqual(true);
expect(
isResourceType(manifest, acceptedResourceTypes)(staticResource)
).toStrictEqual(false);
Expand All @@ -191,23 +250,29 @@ describe('util-manifest', () => {
expect(
isResourceType(manifest, acceptedResourceTypes)(resources[5])
).toStrictEqual(true);
expect(
isResourceType(manifest, acceptedResourceTypes)(resources[6])
).toStrictEqual(true);
expect(
isResourceType(manifest, acceptedResourceTypes)(resources[7])
).toStrictEqual(false);
expect(
isResourceType(manifest, acceptedResourceTypes)(staticResource)
).toStrictEqual(false);
});
it('should filter UI resources', () => {
expect(manifest.resources).toHaveLength(7);
expect(manifest.resources).toHaveLength(9);
expect(
manifest.resources.filter(
isResourceType(manifest, ['custom-ui', 'ui-kit'])
)
).toHaveLength(6);
).toHaveLength(8);
expect(
manifest.resources.filter(isResourceType(manifest, ['custom-ui']))
).toHaveLength(4);
).toHaveLength(5);
expect(
manifest.resources.filter(isResourceType(manifest, ['ui-kit']))
).toHaveLength(2);
).toHaveLength(3);
});
});
});
3 changes: 3 additions & 0 deletions packages/nx-forge/src/shared/manifest/util-manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ const extractionStrategies: Record<string, ExtractionStrategy> = {
(def as Record<string, unknown>)?.edit,
];
},
action: (def) => {
return [(def as Record<string, unknown>)?.config];
},
};

/**
Expand Down