Skip to content

Conversation

@kkartunov
Copy link
Collaborator

@kkartunov kkartunov commented Oct 17, 2025

} = props;
let retUrl;
// eslint-disable-next-line no-restricted-globals
const retUrl = isomorphy.isClientSide() ? location.href : null;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ security]
Using location.href directly can lead to security issues, such as open redirects, if not handled carefully. Consider using a safer method to construct URLs or validate the URL before use.

color: $tc-orange;
}

.data-science-accent-color {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ maintainability]
The addition of .data-science-accent-color seems redundant since it duplicates the existing .datasci-accent-color with the same style. Consider removing one to avoid unnecessary duplication, which can lead to maintenance challenges.

color: $tc-orange;
}

.data-science-accent-color {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ maintainability]
The addition of .data-science-accent-color seems redundant as it duplicates the existing .datasci-accent-color class. Consider removing one to avoid confusion and maintain consistency.

@kkartunov kkartunov merged commit 29d9745 into master Oct 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants