-
Notifications
You must be signed in to change notification settings - Fork 211
[PROD] - Fixes #7122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROD] - Fixes #7122
Conversation
Fixed CSS style issue
PS-423 - fix retUrl in gigs modal
PS-412 - replace taas email
| } = props; | ||
| let retUrl; | ||
| // eslint-disable-next-line no-restricted-globals | ||
| const retUrl = isomorphy.isClientSide() ? location.href : null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[❗❗ security]
Using location.href directly can lead to security issues, such as open redirects, if not handled carefully. Consider using a safer method to construct URLs or validate the URL before use.
| color: $tc-orange; | ||
| } | ||
|
|
||
| .data-science-accent-color { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[maintainability]
The addition of .data-science-accent-color seems redundant since it duplicates the existing .datasci-accent-color with the same style. Consider removing one to avoid unnecessary duplication, which can lead to maintenance challenges.
| color: $tc-orange; | ||
| } | ||
|
|
||
| .data-science-accent-color { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[maintainability]
The addition of .data-science-accent-color seems redundant as it duplicates the existing .datasci-accent-color class. Consider removing one to avoid confusion and maintain consistency.
https://topcoder.atlassian.net/browse/PS-412
https://topcoder.atlassian.net/browse/PS-423
https://topcoder.atlassian.net/browse/PS-411