Conversation
| return ( | ||
| <Link | ||
| className={cn(styles.secondaryNavItem, level3.id === activeChildId && styles.secondaryNavItemOpen)} | ||
| className={cn(styles.secondaryNavItem, level3.id === activeChildId && styles.secondaryNavItemOpen, level3.title === 'All Challenges' && styles.allChallengeClickable)} |
There was a problem hiding this comment.
@LieutenantRoger This not a valid solution, because this is hardcoded if we change the menu to any other sentence this fix will stop working.
| @include Roboto-Bold; | ||
| @include not-clickable; | ||
| } | ||
| &.allChallengeClickable { |
There was a problem hiding this comment.
Also just add CSS class to specific menu name not valid.
luizrrodrigues
left a comment
luizrrodrigues
left a comment
There was a problem hiding this comment.
Please check comments in code.
Also solution need be done in logic of navigation, try check this section:
src/components/TopNav/index.js line: 435
|
This method can't detect the change of the query parameter in the url, this is the reason causing this bug. Please advise otherwise way, maybe passing the query parameter into the TopNav component as well ? Or we can just allow user to re-click/re-enter the same level3 menu item, it doesn't have negative user experience as well IMO. |
|
I'll get confirmation about this and back to you. |
|
@LieutenantRoger Please follow this way:
|
2 participants
No description provided.