Fix timeout propagation after redirects - #3692
Open
Sanjays2402 wants to merge 1 commit into
Open
Conversation
A timeout from a redirected request was raised from its done callback, leaving the original fetch unresolved. Continue redirects through the callback interface so error responses reach the original fetch, and cover the timeout path with a regression test. Fixes tornadoweb#3064
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimpleAsyncHTTPClientfollowed redirects through the public Future API, so a timeout on the redirected request was raised from a done callback and the original fetch never completed. Continue throughfetch_impl's response callback so the 599 error reaches the caller while retaining request defaults.Adds a local redirect-to-stalled-handler regression test. Fixes #3064.