web: Handle CancelledError from request handlers - #3695
Open
Sanjays2402 wants to merge 1 commit into
Open
Conversation
asyncio.CancelledError stopped inheriting from Exception in Python 3.8, so it escaped RequestHandler._execute and left the HTTP request pending. Catch it alongside ordinary exceptions so the existing error path produces a response. Add an HTTP regression test for the cancellation path. Fixes tornadoweb#2990
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asyncio.CancelledErrormoved outsideExceptionin Python 3.8, so a cancelled handler bypassesRequestHandler._execute's error path and leaves the client waiting until its timeout. Catch it explicitly so Tornado returns its normal 500 response.Fixes #2990.
Tested with
ErrorResponseTest(including a regression that times out without the source fix), plus flake8, black, and mypy on the changed files. The full 1,244-test run had only the existing macOStest_no_open_redirectfailure, reproduced unchanged on the base branch.