Added search param to get user profiles function#52
Merged
josecelano merged 1 commit intotorrust:mainfrom Jan 29, 2025
Merged
Conversation
josecelano
approved these changes
Jan 29, 2025
| async getUserProfiles(params: GetUserProfilesParams): Promise<GetUserProfilesResponseData> { | ||
| return await fetchGet<GetUserProfilesResponse>( | ||
| `${this.client.apiBaseUrl}/users?page_size=${params.pageSize}&page=${params.page - 1}`, | ||
| `${this.client.apiBaseUrl}/users?page_size=${params.pageSize}&page=${params.page - 1}${params.searchQuery ? "&search=" + params.searchQuery : ""}`, |
Member
There was a problem hiding this comment.
Hi @mario-nt isn't the param name searchQuery wrong?
In the Index PR I've just merged the param name is search https://github.com/torrust/torrust-index/blob/develop/src/services/torrent.rs#L65?
Member
|
ACK d1c7a0b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #51