Repository navigation
fix: build the apps where the documentation says they are - #22
Merged
Merged
Conversation
script/build and the manual ExampleApp command left the product location to Xcode, which by default is a directory under ~/Library/Developer/Xcode/DerivedData, or Build/Build/Products with -derivedDataPath Build. The paths printed by the script and given in the README, the install guide and the tutorials then did not exist: open Build/Products/Debug/Necto.app and simctl install Build/Products/Debug-iphonesimulator/ExampleApp.app both failed. Both builds now set SYMROOT to Build/Products, as script/test-e2e already does for its own products.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With Xcode's default build location, the README's "Building from source" steps fail on the last line:
script/buildbuilds theNectoscheme without saying where products go, so they land in~/Library/Developer/Xcode/DerivedData/Necto-*/Build/Products/Debug(-showBuildSettingsreportsBUILT_PRODUCTS_DIRthere), while the script printsbuilt: Build/Products/Debug/Necto.app. The ExampleApp build passes-derivedDataPath Build, which puts the app atBuild/Build/Products/Debug-iphonesimulator/ExampleApp.app, so thesimctl install Build/Products/Debug-iphonesimulator/ExampleApp.appline indocs/install.md,docs/tutorial-device.mdanddocs/verification.mdfails too. The release and E2E scripts already handle this (TARGET_BUILD_DIRlookup,SYMROOT=...); the developer-facing path did not.Both builds in
script/buildand the documented ExampleApp command now setSYMROOT="$PWD/Build/Products", which is whatscript/test-e2edoes for its own products.Changelog
script/buildand the install guide put the apps where their instructions say to open them.Test Plan
script/buildend to end on a machine with default Xcode settings (no custom build location): BUILD SUCCEEDED andBuild/Products/Debug/Necto.appexists afterwards (it did not before the change).xcodebuild -project Necto.xcodeproj -scheme ExampleApp -destination 'generic/platform=iOS Simulator' SYMROOT="$PWD/Build/Products" build: BUILD SUCCEEDED, product atBuild/Products/Debug-iphonesimulator/ExampleApp.app.script/test e2e(no iOS 26.2 runtime here); it does not usescript/build.