Skip to content

fix: preserve CODEOWNERS scope and require Node.js 22+ - #30

Merged
ho991217 merged 4 commits into
mainfrom
release/0.0.7
Oct 2, 2026
Merged

ho991217 merged 4 commits into
mainfrom
release/0.0.7

Conversation

@ho991217

@ho991217 ho991217 commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Preserve the matching scope of patterns such as *.ts and docs/ when merging CODEOWNERS files, while retaining the meaning of root-level and explicitly anchored patterns.

Treat only ENOENT as a missing output file. Report other read errors with the file path and stop sync before overwriting any outputs.

Require Node.js 22.8 or later and replace picocolors with the built-in styleText from node:util for CLI output.

Add regression coverage and separate unit tests from CLI integration tests so only integration tests require a build.

Fixes #18
Fixes #20
Fixes #31

its-ho added 3 commits October 1, 2026 21:29
The runtime fix shipped in #16. Extend CLI regressions to check and --cwd, and build the CLI once for all integration suites.
@ho991217 ho991217 self-assigned this Oct 1, 2026
@ho991217 ho991217 added the bug Something isn't working label Oct 1, 2026
@ho991217 ho991217 linked an issue Oct 1, 2026 that may be closed by this pull request
@ho991217 ho991217 changed the title fix: preserve CODEOWNERS pattern scope and report output read errors fix: preserve CODEOWNERS scope and require Node.js 22+ Oct 1, 2026
@ho991217
ho991217 requested a balanced review from Copilot October 2, 2026 06:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Critical test configuration and additional CLI, Windows path, and build-reference issues remain unresolved.

Review effort: Lite
Findings: 1 High severity · 1 Medium severity

Open (2)

Comment thread vitest.config.ts
Comment thread src/core/jobs/codeowners/codeowners-job.ts

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Address the three moderate issues involving stream validation and Vitest global configuration.

Review effort: Lite
Findings: None

Resolved since last review (2)

@ho991217
ho991217 merged commit 4c71914 into main Oct 2, 2026
3 checks passed
@ho991217
ho991217 deleted the release/0.0.7 branch October 2, 2026 07:05
@github-actions github-actions Bot mentioned this pull request Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

3 participants