Catch IO Exceptions for RollingFileLogWritter#472
Merged
samhill303 merged 4 commits intomainfrom Mar 20, 2026
Merged
Conversation
KevinSchildhorn
approved these changes
Mar 11, 2026
Contributor
|
Do we need to keep track of any logs that weren't logged during the exception? For example if I log "Hello World" while the device is logged and in the background will it eventually be logged, or dropped? |
Collaborator
Author
It will be dropped. We could consider adding a buffer in the future, but this at least keeps the coroutine from silently crashing |
KevinSchildhorn
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #468
Catch IO exceptions so that it doesn't crash the coroutine, then start logging again when able. This reduces the impact of the file access getting removed when the device is locked