Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Migrates the mod’s code and build configuration to target the 26.1.1 Minecraft/Fabric ecosystem, updating mixins and world/sign APIs to the newer (Mojang-named) Minecraft classes.
Changes:
- Updated mixins and sign/world helpers to newer Minecraft class/package names and method names.
- Updated build tooling (Gradle wrapper, Loom plugin usage, Java target) and dependency versions for the new platform target.
- Updated world path resolution and sign load behavior to newer server/world types.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/main/java/com/tpwalke2/bluemapsignmarkers/mixin/SignBlockEntityInject.java |
Updates sign text change injection target and types for new Minecraft APIs. |
src/main/java/com/tpwalke2/bluemapsignmarkers/mixin/AbstractBlockInject.java |
Updates block removal hook and sign-block type checks for new Minecraft APIs. |
src/main/java/com/tpwalke2/bluemapsignmarkers/core/signs/persistence/loaders/Version1SignEntryLoader.java |
Updates dimension ID normalization to new world/dimension constants. |
src/main/java/com/tpwalke2/bluemapsignmarkers/core/signs/SignHelper.java |
Updates sign position/world accessors and text component parsing for new APIs. |
src/main/java/com/tpwalke2/bluemapsignmarkers/BlueMapSignMarkersMod.java |
Updates server world types and save path resolution for new APIs. |
gradle/wrapper/gradle-wrapper.properties |
Bumps Gradle wrapper version. |
gradle.properties |
Updates Java/Minecraft/Fabric/BlueMap version pins and property names. |
build.gradle |
Switches Loom plugin id, adjusts dependencies/configuration, updates Java compatibility, and changes Modrinth upload artifact. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 11 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.