release-train: develop -> staging - #660
Merged
Merged
Conversation
…CEBLOC_ prefix (#657) * feat(env): alias-first TRACEBLOC_ENV stage var, normalize toward RFC-0076 Normalize this repo's owned stage-selecting env var toward the RFC-0076 canon (backend#3391), alias-first — read new-or-old, never break an existing deployment. TRACEBLOC_ENV is now the canonical name; the legacy CLIENT_ENV is read as a fallback (remove_by: 2026-12-31). - api.ResolveEnv: --env flag, then $TRACEBLOC_ENV, then legacy $CLIENT_ENV, then prod. Alias precedence lives in one place (stageFromEnv). - doctor: the cluster's stage, read off the jobs-manager Deployment spec, is now read alias-first (stageFromClusterSpec) — a consumer-side alias so the edge chart can adopt the canonical key on its own S3-edge timeline. - auth login / status --check help + the unknown-env error name the canonical var (legacy noted); goldens regenerated. - env-resolution guard registers TRACEBLOC_ENV as a needle so a new read of either name lands in the allowlist; TestMain clears both stage vars so the higher-precedence canonical name can't make CLIENT_ENV-only isolation flaky. - VERSION 0.10.24 -> 0.10.25 (version-bump-gate: env reads are packaged paths). The other RFC-0076 config keys (registry REGISTRY_URL, telemetry, boolean gates) have no owned, unprefixed occurrence here: TRACEBLOC_ALLOW_UNVERIFIED already carries the prefix and no REGISTRY_URL/SKIP_TELEMETRY var exists. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(cli): errcheck TestMain os.Unsetenv + bump VERSION 0.10.26 after develop merge (cli#656) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
bugbot run |
tracebloc-release-train
Bot
added
the
gate-nudge
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2d616f0. Configure here.
tracebloc-release-train
Bot
removed
the
gate-nudge
Contributor
Author
|
Promoted with 1 open Medium/Low Bugbot finding(s), per the severity policy in release-train's README (High stops the line; Medium/Low are recorded and ship, at both hops): Stale docs omit TRACEBLOC_ENV This is a second look at once-reviewed code -- it passed per-feature review on the source branch, and has NOT had functional review yet (that happens on staging). Fix forward on What the train did with each:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated promotion by the release train (RFC-0008 D14). Head is the train-managed
release-train/to-stagingbranch (a mirror ofdevelop), so it never collides with a human PR. Merged only when the fr-gate is green.Note
Low Risk
Backward-compatible env precedence with a single reader and broad tests; wrong routing risk is limited unless both vars disagree and canonical is set incorrectly.
Overview
Bumps the CLI to 0.10.26 and implements RFC-0076 stage naming:
TRACEBLOC_ENVis the canonical process env for dev/stg/prod, with legacyCLIENT_ENVstill honored when the new name is unset (planned alias removal 2026-12-31).api.ResolveEnvand newstageFromEnvcentralize that precedence (--env→$TRACEBLOC_ENV→$CLIENT_ENV→ prod).login/auth statushelp text and unknown-env errors document the new variable.doctorreads the cluster jobs-manager spec the same way viastageFromClusterSpec(TRACEBLOC_ENVthenCLIENT_ENV) for the backend egress probe.Tests and guardrails follow: alias precedence tests, doctor cluster-spec tests,
TestMainclearing both vars for theclipackage, telemetry test isolation, and the env-resolution guard needles/allowlist updated forTRACEBLOC_ENV. Golden help/copy strings updated.Reviewed by Cursor Bugbot for commit 2d616f0. Bugbot is set up for automated code reviews on this repo. Configure here.