Raised by @LukasWodka as a non-blocking note in review of #984, filed separately rather than moving that PR's SHA — two reviewers had verified it at d5968c87 and one had committed to approving.
The stale comment
scripts/lib/cluster.sh:87-88 still says that closing the macOS gap "means a coreutils-free bound usable from a boolean context, which is its own change".
That change shipped in #984. common.sh's _bounded_capture is coreutils-free by construction (its own header says so), returns the child's real status or 124, and is driven from boolean context by _bounded_capture_read.
As written the comment tells the next author that the tool does not exist, when it is already in the tree and already has seven call sites.
Fix
Either point the comment at the primitive, or state why _cluster_presence cannot use it. @LukasWodka's wording: "as written it tells the next author the tool doesn't exist."
Part of #974
Raised by @LukasWodka as a non-blocking note in review of #984, filed separately rather than moving that PR's SHA — two reviewers had verified it at
d5968c87and one had committed to approving.The stale comment
scripts/lib/cluster.sh:87-88still says that closing the macOS gap "means a coreutils-free bound usable from a boolean context, which is its own change".That change shipped in #984.
common.sh's_bounded_captureis coreutils-free by construction (its own header says so), returns the child's real status or 124, and is driven from boolean context by_bounded_capture_read.As written the comment tells the next author that the tool does not exist, when it is already in the tree and already has seven call sites.
Fix
Either point the comment at the primitive, or state why
_cluster_presencecannot use it. @LukasWodka's wording: "as written it tells the next author the tool doesn't exist."Part of #974