Raised by @LukasWodka in review of #984, explicitly as "a note, not a finding". Filed so the choice stays visible rather than to force a change.
The divergence
scripts/lib/cluster.sh:1206:
error "Couldn't start your existing secure environment. Check Docker is running, then re-run."
It is reachable straight off the rc-2 path, and it keeps the Docker attribution that its sibling at :944 just dropped in #984.
Why it may be correct as-is
@LukasWodka's own read, recorded so nobody "fixes" this without seeing it: a failed start is a real action failure, unlike a failed listing, and :929-931 shows the sentence is deliberate for a wedged engine. So this is plausibly right and the two messages are meant to differ.
What to decide
Either add a sentence at :1206 saying why it diverges from :944 deliberately, or align it. The point of the issue is that the divergence should be a recorded decision rather than an accident of which line got reworded — as it stands, a reader comparing the two cannot tell which it is.
Part of #974
Raised by @LukasWodka in review of #984, explicitly as "a note, not a finding". Filed so the choice stays visible rather than to force a change.
The divergence
scripts/lib/cluster.sh:1206:It is reachable straight off the rc-2 path, and it keeps the Docker attribution that its sibling at
:944just dropped in #984.Why it may be correct as-is
@LukasWodka's own read, recorded so nobody "fixes" this without seeing it: a failed start is a real action failure, unlike a failed listing, and
:929-931shows the sentence is deliberate for a wedged engine. So this is plausibly right and the two messages are meant to differ.What to decide
Either add a sentence at
:1206saying why it diverges from:944deliberately, or align it. The point of the issue is that the divergence should be a recorded decision rather than an accident of which line got reworded — as it stands, a reader comparing the two cannot tell which it is.Part of #974