Hash value of null breaks parsing#264
Merged
yogeshjain999 merged 3 commits intotrailblazer:masterfrom Dec 21, 2022
Merged
Conversation
Member
|
@toadle thanks for creating the PR! Changes looks good to me! Could you also add test for this ? |
Author
|
@yogeshjain999 here you go! |
test/hash_bindings_test.rb
Outdated
| result = nil | ||
| begin | ||
| result = @property.read(nil, "song") | ||
| rescue NoMethodError |
Member
There was a problem hiding this comment.
@toadle we don't have to consider rescuing NoMethodError now as we know it shouldn't occur. If it does, then it must be due to some other bug and should be handled differently.
So in this test, we can just assert on return value of read, like in above test.
it "..." do
assert_equal Representable::Binding::FragmentNotFound, @property.read(nil, "song")
end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey everybody, I don't now if this would belong into #203
but I had a GraphQL-JSON-collection that I tried to parse with
representable.Because of an error the collection came out as:
This completely broke the parsing flow and error-out with
NoMethodError: undefined method has_key? for nil:NilClassonrepresentable/lib/representable/hash/binding.rb
Line 12 in df685c8
Expected behaviour would have been to just return nothing. I could even imagine a scenario, where
null-entries would result innil.I resorted to filter the collection with a
skip_parse-first, but an exception in this case is kinda annoying.