UI improvements for sketch/shape lists and coding style guidance#99
Merged
UI improvements for sketch/shape lists and coding style guidance#99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sketch_inspection_mode.GUI::list_name_field_width_..cpporganization, helper placement near use, and pragmatic DRY guidance.Files Changed
src/gui.cppsrc/gui.hsrc/gui_settings.cppezycad_code_style.md.cursor/rules/ezycad_code_style.mdcagents/issues/003-ui-improvements-sketch-shape-lists-and-style.mdRelated
Test Plan
EzyCad_libin Release config.Note
Low Risk
Low risk UI-focused changes; main behavior change is auto-switching to
Sketch_inspection_modewhen selecting a sketch, which could affect user workflow but doesn’t touch persistence or core geometry logic.Overview
Improves list-pane usability by making Sketch List selection automatically switch to
Mode::Sketch_inspection_mode, and by adding horizontal scrolling plus consistent, capped name input widths in both Sketch and Shape lists via sharedGUI::list_name_field_width_.Tightens a small settings path by asserting sketches are non-null before updating underlay tint, and updates
ezycad_code_style.mdwith reader-first.cpporganization, local declaration placement, and pragmatic DRY guidance. Adds draft issue/PR markdowns for tracking follow-ups.Reviewed by Cursor Bugbot for commit a2f7fbf. Bugbot is set up for automated code reviews on this repo. Configure here.