[pull] master from golang:master#18
Merged
pull[bot] merged 10 commits intotrailofbits:masterfrom May 6, 2026
Merged
Conversation
This CL implements the proposed API from #61902 as unexported methods and uses it as the basis for the FindAll variants. The overall speed is about the same. The methods are unexported so that the CL can be committed without waiting for the proposal to be accepted. The non-submatch versions no longer compute submatch information only to discard it. The CL also updates the doc comments on each method to stand alone instead of referring back to the top-level doc comment. This should work better for anyone using a selective doc comment reader such as 'go doc regexp Regexp.FindAll' or an IDE. benchmark \ host local s7 s7:GOARCH=386 linux-386 linux-amd64 linux-arm64 vs base vs base vs base vs base vs base vs base Find ~ ~ ~ ~ ~ ~ FindAllNoMatches ~ -2.21% -2.55% ~ ~ -3.65% FindAllTenMatches ~ +6.58% +3.77% ~ ~ +1.10% FindString ~ ~ ~ ~ ~ ~ FindSubmatch ~ ~ ~ ~ ~ +2.35% FindStringSubmatch ~ ~ ~ ~ ~ -0.37% For #61902. Change-Id: I7d45e2322bf6c7617fda48b572a7e29cb5fca719 Reviewed-on: https://go-review.googlesource.com/c/go/+/742801 Reviewed-by: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Fixes #74609 Change-Id: I681b13aed197e215157d41322a117171a567a1e8 Reviewed-on: https://go-review.googlesource.com/c/go/+/774620 Reviewed-by: Cherry Mui <cherryyz@google.com> Auto-Submit: Austin Clements <austin@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
RFC 2253 §2.4 says that an AttributeValue should be rendered as a string when its ASN.1 type has a string representation, reserving the prefixed hex form for types that don't. RDNSequence.String previously hex-encoded any value whose OID wasn't in attributeTypeNames, even when the value was already a Go string. Render string-typed values directly; the existing escape logic handles RFC 2253 special characters. Fixes #33093 Change-Id: Idb8acd907f9dac902790c9ac7d0bc0cb36b5b918 Reviewed-on: https://go-review.googlesource.com/c/go/+/773800 Reviewed-by: Cherry Mui <cherryyz@google.com> Auto-Submit: Daniel McCarney <daniel@binaryparadox.net> Reviewed-by: Roland Shoemaker <roland@golang.org> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Using rr.VCS.Name as done in CL 729500 works for vcsMod, but for all other VCSes the counter name would've ended up like go/vcs:Mercurial or go/vcs:Git. Use the Cmd field instead, it should be stable enough. For #76801. Change-Id: Ib36c4fcd49c44ebd7898b5bc40f5d63495cd90e4 Reviewed-on: https://go-review.googlesource.com/c/go/+/774600 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Roland Shoemaker <roland@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Change-Id: I08ade4ff3622007cf9e0e3b7a3cd0b9ad1e462ed GitHub-Last-Rev: abf4ca5 GitHub-Pull-Request: #79030 Reviewed-on: https://go-review.googlesource.com/c/go/+/772060 Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org> Auto-Submit: Keith Randall <khr@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
…rrors When reporting layout cycles involving instantiated generic types, the error chain omitted type arguments, making the output confusing since the generic type itself makes no reference to the recursive type. Fixes #75022 Change-Id: Ibd2c22afd9dbab03ab1df80d41e50b8cc5514ff0 GitHub-Last-Rev: 62264fd GitHub-Pull-Request: #78006 Reviewed-on: https://go-review.googlesource.com/c/go/+/752580 TryBot-Bypass: Mark Freeman <markfreeman@google.com> Reviewed-by: Robert Griesemer <gri@google.com> Auto-Submit: Robert Griesemer <gri@google.com> Reviewed-by: Mark Freeman <markfreeman@google.com>
When encountering an undecodable encoded-word, skip over the entire word rather than just the initial "=?". Fixes #79217 Fixes CVE-2026-42504 Change-Id: I28605faa235459d2ba71bd0f3ae3dce96a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/774481 Reviewed-by: Nicholas Husin <nsh@golang.org> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Nicholas Husin <husin@google.com>
notag.go ``` package repro ``` tag.go ``` //go:build ignore package repro ``` Change-Id: I6eb2f61f3434ac575e9081747c8da8aab24f4823 Reviewed-on: https://go-review.googlesource.com/c/go/+/772800 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Mark Freeman <markfreeman@google.com> Reviewed-by: Nicholas Husin <nsh@golang.org> Reviewed-by: Nicholas Husin <husin@google.com> Auto-Submit: Neal Patel <nealpatel@google.com>
In this example, Tau is not deprecated, and Old is deprecated. The current cmd/api check produces false reports in both cases. The next CL fixes this. For #79145. Change-Id: I670fa01bb67d7ee58f1bcca9061494bd9b0105bf Reviewed-on: https://go-review.googlesource.com/c/go/+/774880 Reviewed-by: Alan Donovan <adonovan@google.com> TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
It is made very clear at https://go.dev/wiki/Deprecated and at https://go.dev/ref/mod#go-mod-file-module-deprecation that a Deprecated: prefix must be at the start of a paragraph; it cannot be in the middle of a paragraph, nor can it be in the middle of a sentence (as demonstrated above). Update isDeprecated accordingly. This involves updating a frozen api/go1.16.txt file to correct the fact that go/importer.ForCompiler was accidentally listed as deprecated. The API of Go 1.16 itself isn't changing, this is merely a consequence of the cmd/api checker in Go 1.27 starting to report a more accurate actual API after receiving this bug fix. Fortunately there was nothing else in the standard library affected by this. For #79139. Fixes #79145. Change-Id: I456b88e3253cacb230aa7c3c5ab4972c80c356e6 Reviewed-on: https://go-review.googlesource.com/c/go/+/774881 TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )