⚡ Bolt: [performance improvement] Use sync.Pool for bytes.Buffer in ResponseWriterWrapper - #355
Conversation
Replaced the frequent allocation of `bytes.Buffer` in `ResponseWriterWrapper` with a `sync.Pool`. The API gateway's `gin.ResponseWriter` wrapper allocated a new `bytes.Buffer` on every request to capture the response body (for non-streaming requests). This generated excessive allocations and garbage collection pressure at high request volumes. This change reduces allocations per request for the buffer from 1 to 0, which scales massively given this is in the hot path of the API gateway. Also includes capacity checks to prevent permanent memory bloat from pooling excessively large buffers. Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Replaced the frequent allocation of
bytes.BufferinResponseWriterWrapperwith async.Pool.🎯 Why: The API gateway's
gin.ResponseWriterwrapper allocated a newbytes.Bufferon every request to capture the response body (for non-streaming requests). This generated excessive allocations and garbage collection pressure at high request volumes.📊 Impact: Reduces allocations per request for the buffer from 1 to 0, which scales massively given this is in the hot path of the API gateway.
🔬 Measurement: Benchmarks show 0 allocs/op with
sync.Poolcompared to 1 alloc/op, dropping memory footprint on high volume. Includes capacity check to prevent memory bloat.PR created automatically by Jules for task 10601097450361305867 started by @rschumann