Keep internal pricing history out of the published landing page - #38
Merged
Conversation
I wrote the rationale for the rewrite into web/index.html as source comments -- naming the retired plans, their $39/$79/$149 prices, and the money-back incident. web/ IS the website. Cloudflare Workers serves ./web directly (wrangler.jsonc assets.directory) and the Pages job does `cp -rL web/. _site/`. So that history shipped to anyone who hit View Source on get.traylinx.com; confirmed against the live deploy. The suite did not catch it because my own assertion stripped `//` comments before scanning -- it was checking rendered copy when the whole file is public. Both comments now point at tests/landing-pricing.test.mjs (outside web/, not served) for the history. The two claim assertions scan the ENTIRE file, comments included, and a new one forbids any $NN literal anywhere in it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
tytus-cli | b5f627c | Jul 26 2026, 08:37 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #37.
What I got wrong
I wrote the rationale for the rewrite into
web/index.htmlas source comments — naming the retired plans, their $39/$79/$149 prices, and the money-back incident.web/is the website. Cloudflare Workers serves./webdirectly (wrangler.jsonc→assets.directory) and the Pages job doescp -rL web/. _site/. So that history shipped to anyone who hit View Source on get.traylinx.com. Confirmed against the live deploy:The suite didn't catch it because my own assertion stripped
//comments before scanning — it was checking rendered copy when the whole file is public.Fix
tests/landing-pricing.test.mjs(outsideweb/, not served) for the history$NNliteral may appear anywhere in the published file18 assertions, all passing.
🤖 Generated with Claude Code