fix bug where the before_commit hook runs before the after_begin hook#17
fix bug where the before_commit hook runs before the after_begin hook#17wjordan213 wants to merge 4 commits intomasterfrom
Conversation
…ey can happen out of order
|
PR that introduced issue here: https://github.com/trialspark/sqlalchemy-continuum/pull/14/files |
|
Figuring out how to run tests against this repo now |
wjordan213
force-pushed
the
wjordan213__PLATFORM-943__merge_after_begin_and_before_commit_hooks
branch
from
42562b8 to
308f203
Compare
rmurcek
left a comment
rmurcek
left a comment
There was a problem hiding this comment.
LGTM assuming the continuum tests pass and the spark tests pass when pointed at this version!
minznerjosh
left a comment
minznerjosh
left a comment
There was a problem hiding this comment.
I think this is fine? Have you run all the automated tests for contiuum? (We don't have CI set up for this repo so you'll need to do it locally.)
|
yeah were the tests running properly before? I'm unable to run any tests against even master using: |
|
getting random schema errors and things |
|
@minznerjosh if I ran this against the spark repo's codebase would that be sufficient? |
3 participants
Merge the before commit and after begin hooks due to the fact that they can happen out of order.
This addresses an issue that I was having when testing the DMR project locally. I observed rows being added to the audit transactions table that did not contain a value for origin_app. Implementing this change in the library code running inside of the docker container executing the data migration fixed the issue that I was having.