Skip to content

Fix erroneous semicolons with void returns#256

Open
cruzzil wants to merge 1 commit intotrifectatechfoundation:mainfrom
cruzzil:clippy_semicolon_if_nothing_returned
Open

Fix erroneous semicolons with void returns#256
cruzzil wants to merge 1 commit intotrifectatechfoundation:mainfrom
cruzzil:clippy_semicolon_if_nothing_returned

Conversation

@cruzzil
Copy link
Contributor

@cruzzil cruzzil commented Dec 25, 2025

Fixed lints from clippy::semicolon_if_nothing_returned

@cruzzil cruzzil force-pushed the clippy_semicolon_if_nothing_returned branch from 8d129d1 to 1c99813 Compare February 28, 2026 06:35
@codecov
Copy link

codecov bot commented Feb 28, 2026

Codecov Report

❌ Patch coverage is 68.00000% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/decompress/zstd_decompress_block.rs 60.00% 2 Missing ⚠️
lib/dictBuilder/fastcover.rs 0.00% 2 Missing ⚠️
lib/common/pool.rs 50.00% 1 Missing ⚠️
lib/compress/zstd_compress.rs 0.00% 1 Missing ⚠️
lib/compress/zstd_compress_literals.rs 0.00% 1 Missing ⚠️
lib/dictBuilder/zdict.rs 50.00% 1 Missing ⚠️
Flag Coverage Δ
test-aarch64-apple-darwin 33.44% <65.21%> (-0.02%) ⬇️
test-aarch64-unknown-linux-gnu 31.65% <65.21%> (-0.01%) ⬇️
test-i686-unknown-linux-gnu 31.71% <66.66%> (-0.02%) ⬇️
test-x86_64-unknown-linux-gnu 33.29% <68.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/common/allocations.rs 82.92% <100.00%> (ø)
lib/common/mem.rs 96.87% <100.00%> (ø)
lib/common/xxhash.rs 96.46% <100.00%> (ø)
lib/decompress/zstd_decompress.rs 60.79% <100.00%> (-0.04%) ⬇️
lib/dictBuilder/cover.rs 80.90% <100.00%> (ø)
lib/legacy/zstd_v07.rs 69.65% <100.00%> (+0.01%) ⬆️
lib/polyfill.rs 90.69% <100.00%> (ø)
lib/common/pool.rs 59.24% <50.00%> (ø)
lib/compress/zstd_compress.rs 37.73% <0.00%> (ø)
lib/compress/zstd_compress_literals.rs 70.56% <0.00%> (ø)
... and 3 more

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cruzzil
Copy link
Contributor Author

cruzzil commented Feb 28, 2026

@folkertdev anything pending on this one?

@folkertdev
Copy link
Member

I don't really like how this looks. It's a nonstandard lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants