Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/VOUCHED.td
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ myftija
nicktrn
samejr
isshaddad
# Bots
devin-ai-integration[bot]
# Outside contributors
gautamsi
capaj
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/vouch-check-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ jobs:
github.event.pull_request.draft == false &&
github.event.pull_request.author_association != 'MEMBER' &&
github.event.pull_request.author_association != 'OWNER' &&
github.event.pull_request.author_association != 'COLLABORATOR'
github.event.pull_request.author_association != 'COLLABORATOR' &&
github.event.pull_request.user.login != 'devin-ai-integration[bot]'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Bot exemption bypasses the draft-PR gate entirely

The new condition github.event.pull_request.user.login != 'devin-ai-integration[bot]' at line 31 causes the entire require-draft job to be skipped for the bot. This means the bot can open non-draft PRs without being closed — which is presumably intentional, but it also means the bot won't receive the CONTRIBUTING.md reminder comment that other external contributors get. If the bot ever opens a PR that shouldn't have been non-draft (e.g., a misconfigured run), there's no guardrail. This is a policy tradeoff rather than a bug, but worth the reviewer confirming this is the desired behavior.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

runs-on: ubuntu-latest
steps:
- name: Close non-draft PR
Expand Down
Loading