Conversation
|
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
WalkthroughThis change updates the skills documentation file by removing the "new" tag from the frontmatter, reformatting a note section for clarity, and adding a new skill example called Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/skills.mdx (1)
56-56: Clarify the distinction between "Use for" and "Covers" columns.The "Use for" and "Covers" columns for
trigger-cost-savingscontain overlapping content. The "Use for" column should describe when/why to use this skill, while "Covers" should list the specific topics, patterns, or techniques it covers.For example:
- Use for: "Reducing costs and improving performance in Trigger.dev tasks"
- Covers: "Rate limiting, batching, caching strategies, resource allocation, execution optimization"
Compare with other rows like
trigger-taskswhere "Use for" describes the use case ("Writing background tasks...") and "Covers" lists specific features ("Triggering, waits, queues, retries...").🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/skills.mdx` at line 56, The "Use for" and "Covers" columns for the `trigger-cost-savings` row currently repeat the same phrases; update them so "Use for" explains when/why to use the skill (e.g., "Reducing costs and improving performance in Trigger.dev tasks") and "Covers" enumerates concrete topics and techniques (e.g., "Rate limiting, batching, caching strategies, resource allocation, execution optimization"), mirroring the distinction used in the `trigger-tasks` row; locate the table row containing `trigger-cost-savings` and replace the left cell with a concise use-case sentence and the right cell with a comma-separated list of specific topics/patterns.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/skills.mdx`:
- Line 56: The "Use for" and "Covers" columns for the `trigger-cost-savings` row
currently repeat the same phrases; update them so "Use for" explains when/why to
use the skill (e.g., "Reducing costs and improving performance in Trigger.dev
tasks") and "Covers" enumerates concrete topics and techniques (e.g., "Rate
limiting, batching, caching strategies, resource allocation, execution
optimization"), mirroring the distinction used in the `trigger-tasks` row;
locate the table row containing `trigger-cost-savings` and replace the left cell
with a concise use-case sentence and the right cell with a comma-separated list
of specific topics/patterns.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 92667582-f2e7-4b47-8c7f-7f468edf2f4b
📒 Files selected for processing (1)
docs/skills.mdx
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Mintlify Deployment
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (python)
- GitHub Check: Analyze (actions)
🧰 Additional context used
📓 Path-based instructions (1)
docs/**/*.mdx
📄 CodeRabbit inference engine (docs/CLAUDE.md)
docs/**/*.mdx: MDX documentation pages must include frontmatter with title (required), description (required), and sidebarTitle (optional) in YAML format
Use Mintlify components for structured content: , , , , , , /, /
Always import from@trigger.dev/sdkin code examples (never from@trigger.dev/sdk/v3)
Code examples must be complete and runnable where possible
Use language tags in code fences:typescript,bash,json
Files:
docs/skills.mdx
🧠 Learnings (10)
📓 Common learnings
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3200
File: docs/config/config-file.mdx:353-368
Timestamp: 2026-03-10T12:44:19.869Z
Learning: In the triggerdotdev/trigger.dev repository, docs PRs are often written as companions to implementation PRs (e.g., PR `#3200` documents features being added in PR `#3196`). When reviewing docs PRs, the documented features may exist in a companion/companion PR branch rather than main. Always check companion PRs referenced in the PR description before flagging missing implementations.
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: packages/cli-v3/CLAUDE.md:0-0
Timestamp: 2026-03-02T12:43:34.140Z
Learning: Keep SDK documentation in `rules/` and `.claude/skills/trigger-dev-tasks/` synchronized when features are added or changed
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: packages/cli-v3/CLAUDE.md:0-0
Timestamp: 2026-03-02T12:43:34.140Z
Learning: Applies to packages/cli-v3/.claude/skills/trigger-dev-tasks/**/* : Update `.claude/skills/trigger-dev-tasks/` in parallel with `rules/` when SDK features change
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: packages/trigger-sdk/CLAUDE.md:0-0
Timestamp: 2026-03-02T12:43:48.124Z
Learning: Do NOT update `.claude/skills/trigger-dev-tasks/` directory files unless explicitly asked - these are maintained in separate dedicated passes
📚 Learning: 2026-03-02T12:43:34.140Z
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: packages/cli-v3/CLAUDE.md:0-0
Timestamp: 2026-03-02T12:43:34.140Z
Learning: Keep SDK documentation in `rules/` and `.claude/skills/trigger-dev-tasks/` synchronized when features are added or changed
Applied to files:
docs/skills.mdx
📚 Learning: 2026-03-02T12:43:34.140Z
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: packages/cli-v3/CLAUDE.md:0-0
Timestamp: 2026-03-02T12:43:34.140Z
Learning: Applies to packages/cli-v3/.claude/skills/trigger-dev-tasks/**/* : Update `.claude/skills/trigger-dev-tasks/` in parallel with `rules/` when SDK features change
Applied to files:
docs/skills.mdx
📚 Learning: 2026-03-25T15:29:25.889Z
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.889Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `schemaTask()` from `trigger.dev/sdk` with a Zod schema for payload validation
Applied to files:
docs/skills.mdx
📚 Learning: 2026-03-25T15:29:25.889Z
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.889Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Import from `trigger.dev/sdk` (NEVER from `trigger.dev/sdk/v3`)
Applied to files:
docs/skills.mdx
📚 Learning: 2026-03-25T15:29:25.889Z
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.889Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `task()` from `trigger.dev/sdk` for basic task definitions with `id` and `run` properties
Applied to files:
docs/skills.mdx
📚 Learning: 2026-03-25T15:29:25.889Z
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.889Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `schedules.task()` for scheduled (cron) tasks with either declarative cron patterns or imperative schedule creation
Applied to files:
docs/skills.mdx
📚 Learning: 2026-03-25T15:29:25.889Z
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.889Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use lifecycle hooks (`init`, `cleanup`, `onStart`, `onSuccess`, `onFailure`, `handleError`) to manage task execution stages
Applied to files:
docs/skills.mdx
📚 Learning: 2026-03-25T15:29:25.889Z
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.889Z
Learning: Run `npx trigger.devlatest init` to initialize a new Trigger.dev project
Applied to files:
docs/skills.mdx
📚 Learning: 2026-03-10T12:44:14.176Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3200
File: docs/config/config-file.mdx:353-368
Timestamp: 2026-03-10T12:44:14.176Z
Learning: In the trigger.dev repo, docs PRs are often companions to implementation PRs. When reviewing docs PRs (MDX files under docs/), check the PR description for any companion/related PR references and verify that the documented features exist in those companion PRs before flagging missing implementations. This ensures docs stay in sync with code changes across related PRs.
Applied to files:
docs/skills.mdx
🔇 Additional comments (3)
docs/skills.mdx (3)
1-15: LGTM! Frontmatter and Note formatting are correct.The frontmatter includes all required fields, and the Note block reformatting improves readability while maintaining the same meaning.
35-47: LGTM! New skill CLI example added correctly.The CLI installation example for
trigger-cost-savingsfollows the same pattern as other skills and is properly formatted.
45-45:⚠️ Potential issue | 🔴 CriticalAdd the missing
trigger-cost-savingsskill implementation or defer documentation until the skill is ready.The documentation references a
trigger-cost-savingsskill at lines 45 and 56, but the skill implementation does not exist in the repository. The.claude/skills/directory contains onlyspan-timeline-eventsandtrigger-dev-tasks, with notrigger-cost-savingsdirectory.Either:
- Create the skill at
.claude/skills/trigger-cost-savings/SKILL.md(following the pattern of existing skills), or- Remove the references from the documentation until the skill is implemented, or
- Reference this as a companion PR if the implementation exists in a separate PR branch.
This applies to lines 45 and 56 in the code block and table.
⛔ Skipped due to learnings
Learnt from: CR Repo: triggerdotdev/trigger.dev PR: 0 File: packages/cli-v3/CLAUDE.md:0-0 Timestamp: 2026-03-02T12:43:34.140Z Learning: Keep SDK documentation in `rules/` and `.claude/skills/trigger-dev-tasks/` synchronized when features are added or changedLearnt from: nicktrn Repo: triggerdotdev/trigger.dev PR: 3200 File: docs/config/config-file.mdx:353-368 Timestamp: 2026-03-10T12:44:19.869Z Learning: In the triggerdotdev/trigger.dev repository, docs PRs are often written as companions to implementation PRs (e.g., PR `#3200` documents features being added in PR `#3196`). When reviewing docs PRs, the documented features may exist in a companion/companion PR branch rather than main. Always check companion PRs referenced in the PR description before flagging missing implementations.Learnt from: CR Repo: triggerdotdev/trigger.dev PR: 0 File: packages/cli-v3/CLAUDE.md:0-0 Timestamp: 2026-03-02T12:43:34.140Z Learning: Applies to packages/cli-v3/.claude/skills/trigger-dev-tasks/**/* : Update `.claude/skills/trigger-dev-tasks/` in parallel with `rules/` when SDK features changeLearnt from: CR Repo: triggerdotdev/trigger.dev PR: 0 File: packages/trigger-sdk/CLAUDE.md:0-0 Timestamp: 2026-03-02T12:43:48.124Z Learning: Do NOT update `.claude/skills/trigger-dev-tasks/` directory files unless explicitly asked - these are maintained in separate dedicated passesLearnt from: CR Repo: triggerdotdev/trigger.dev PR: 0 File: .cursor/rules/writing-tasks.mdc:0-0 Timestamp: 2026-03-25T15:29:25.889Z Learning: Run `npx trigger.devlatest init` to initialize a new Trigger.dev project
2 participants
No description provided.