Skip to content

feat(webapp): add RUNTIME_API_ORIGIN to decouple runner traffic from external origin - #4435

Closed
deepshekhardas wants to merge 1 commit into
triggerdotdev:mainfrom
deepshekhardas:fix/runtime-api-origin
Closed

feat(webapp): add RUNTIME_API_ORIGIN to decouple runner traffic from external origin#4435
deepshekhardas wants to merge 1 commit into
triggerdotdev:mainfrom
deepshekhardas:fix/runtime-api-origin

Conversation

@deepshekhardas

Copy link
Copy Markdown

Rebased version of #3686. Adds RUNTIME_API_ORIGIN env var, which routes managed runner TRIGGER_API_URL/TRIGGER_STREAM_URL through an in-cluster origin (bypassing tracing gateways that rewrite traceparent). Dev CLI runs unaffected. Updates docker-compose, helm chart, .env.example, and docs. Closes #3686.

@changeset-bot

changeset-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 29b5c66

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

Hi @deepshekhardas, thanks for your interest in contributing!

This project requires that pull request authors are vouched, and you are not in the list of vouched users.

This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details.

@github-actions github-actions Bot closed this Jul 31, 2026
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 52b1d713-7754-4194-9ca0-6cd7d6fb1833

📥 Commits

Reviewing files that changed from the base of the PR and between debfa2b and 29b5c66.

📒 Files selected for processing (8)
  • .server-changes/runtime-api-origin.md
  • apps/webapp/app/env.server.ts
  • apps/webapp/app/v3/environmentVariables/environmentVariablesRepository.server.ts
  • docs/self-hosting/env/webapp.mdx
  • hosting/docker/.env.example
  • hosting/docker/webapp/docker-compose.yml
  • hosting/k8s/helm/templates/webapp.yaml
  • hosting/k8s/helm/values.yaml

Walkthrough

The webapp now accepts an optional RUNTIME_API_ORIGIN value and normalizes blank values to undefined. Production managed runner API and stream URLs prefer this value and retain existing origin fallbacks when it is unset. Docker Compose and Helm deployment configuration can provide the value. Self-hosting documentation and the server change entry describe its use.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant