Conversation
thesujai
requested review from
bhaveshpatel640,
chiragjn,
debajyoti-truefoundry,
heerambavi1998 and
sr07asthana
as code owners
September 16, 2026 12:25
🦋 Changeset detectedLatest commit: 49bd3b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0c9ae4b. Configure here.
…ntinel and add TypeScript error handling
…and improve error handling in helpers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
feat: add Redis Sentinel and TLS support in TrueForge
Closes AGE-2071
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,python/trueforge_sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Medium Risk
Changes how every peered replica connects to Redis and how Helm injects Redis config; misconfiguration or Sentinel/TLS edge cases could block startup or break executor peering until fixed.
Overview
Distributed TrueForge can now connect to Redis via URL, host/port + auth, Redis Sentinel, and optional TLS/mTLS, instead of relying on a single
REDIS_URLwith a localhost default.The server reads a broader
REDIS_*env surface (host, port, DB, credentials, TLS material, Sentinel nodes/master/auth).connectRedischooses Sentinel vs URL vs host mode, applies shared TLS socket options, loads PEM from paths or inline text, and rebuilds Sentinel clients on connect failure (except auth errors). Request-reply and event streaming use a sharedRedisPeerClienttype; Sentinel reuses one client for pub/sub (noduplicate()subscriber), with shutdown adjusted accordingly.The Helm chart maps expanded
externalRedis(url/host/auth/tls/sentinel) into those env vars, adds render-time validation (bundled vs external mutual exclusion, required fields), and documents upgrade-friendlyexternalRedis.enabledbehavior..env.exampleand chart README/NOTES are updated to match.Reviewed by Cursor Bugbot for commit 49bd3b1. Bugbot is set up for automated code reviews on this repo. Configure here.