feat: upload TFY sandbox files without stuffing them onto exec argv - #786
Open
bhaveshpatel640 wants to merge 11 commits into
Open
bhaveshpatel640 wants to merge 11 commits into
bhaveshpatel640 wants to merge 11 commits into
Conversation
bhaveshpatel640
requested review from
chiragjn,
debajyoti-truefoundry,
heerambavi1998,
sr07asthana and
thesujai
as code owners
September 17, 2026 09:01
🦋 Changeset detectedLatest commit: 4672161 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1aa7f58. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #416
Summary
Upload TFY sandbox files as raw bytes instead of base64 on exec argv, so large files don't hit command-line limits.
Closes AGE-2266
Depends on : https://github.com/truefoundry/tfy-sandbox-server/pull/26
Changes
execuploadFile)How was this tested?
Unit tests in
packages/trueforge-core/tests/core/sandbox/provider/tfyUpload.test.tsviapnpm test:trueforge-coreChecklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,python/trueforge_sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Medium Risk
Behavior change depends on the companion tfy-sandbox-server upload API; misconfiguration or server mismatch would break uploads, though tenant checks reduce cross-tenant risk.
Overview
TFY sandbox file uploads no longer pipe base64 through
exec(echo … | base64 -d).TFYSandboxProvider.uploadFilenow POSTs raw bytes to{serverUrl}/files/uploadwithsandbox_idandpathquery params,Content-Type: application/octet-stream, and a 30-minute client abort (aligned with Daytona’s default).Uploads validate tenant ownership of the sandbox ID before any network call, and failures surface HTTP status text or the JSON
{ success: false, error }body. Unit tests intfyUpload.test.tscover the request shape, server errors, and tenant mismatch.Reviewed by Cursor Bugbot for commit 4672161. Bugbot is set up for automated code reviews on this repo. Configure here.