fix(local-sandbox): allow SRT proxy sockets on Linux - #798
Merged
chiragjn merged 3 commits intoSep 18, 2026
Merged
Conversation
sirmace72
requested review from
bhaveshpatel640,
chiragjn,
debajyoti-truefoundry,
heerambavi1998,
sr07asthana and
thesujai
as code owners
September 18, 2026 01:56
🦋 Changeset detectedLatest commit: 5f24fb3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
Thank you for raising this fix, we will do some testing and get this in |
chiragjn
force-pushed
the
fix/local-sandbox-pypi-proxy
branch
from
September 18, 2026 12:55
8994f1d to
6abf816
Compare
chiragjn
approved these changes
Sep 18, 2026
chiragjn
force-pushed
the
fix/local-sandbox-pypi-proxy
branch
from
September 18, 2026 14:29
6abf816 to
53b2cb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #482
Summary
Allow the Linux local sandbox to read the SRT HTTP/SOCKS Unix socket paths without exposing unrelated host paths.
This fixes sandboxed network access that could fail when
denyRead: ['/']hid the SRT proxy bridge sockets.Changes
/tmppaths hiddenValidation
pnpm smoke:local-sandboxpnpm --filter @truefoundry/trueforge typecheckpnpm --filter @truefoundry/trueforge test:local-sandbox:contractAll passed.
Note
Medium Risk
Narrows the sandbox filesystem read policy for Linux; regression tests assert SRT sockets stay reachable while unrelated host
/tmpand home secrets remain blocked.Overview
Fixes Linux local sandbox HTTPS/pip-style network failures when broad
denyRead: ['/']blocked the SRT HTTP/SOCKS bridge Unix sockets under host/tmp.hostRun.tsnow adds a Linux-only read allowlist for the exact paths fromSandboxManager.getLinuxHttpSocketPath()andgetLinuxSocksSocketPath(), merged intofilesystemPolicyalongside the existing sandbox root and Code Mode socket parent entries—without opening all of host/tmp.Smoke coverage adds
smokeLinuxSrtProxySocketReadGate(stat the HTTP bridge socket, assert an unrelated/tmpsentinel stays invisible) and tightens host-home isolation by probing a secret file under$HOMEinstead of only listing$HOME. Lima provisioning installspython3-venvfor the guest smoke environment.Reviewed by Cursor Bugbot for commit 5f24fb3. Bugbot is set up for automated code reviews on this repo. Configure here.