Conversation
thesujai
requested review from
bhaveshpatel640,
chiragjn,
debajyoti-truefoundry,
heerambavi1998 and
sr07asthana
as code owners
September 18, 2026 06:50
🦋 Changeset detectedLatest commit: 8229f0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thesujai
requested review from
govindavashishtha,
kumarsks619,
qaifi-tf,
sajal-truefoundry,
sayan-truefoundry and
vinit-truefoundry
as code owners
September 18, 2026 09:35
thesujai
commented
Sep 18, 2026
| SET name = manifest ->> 'type' | ||
| WHERE name IS NULL | ||
| `.execute(db); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
tenant_id and name will be a unique constraint
…fter main Co-authored-by: Cursor <cursoragent@cursor.com>
thesujai
force-pushed
the
feat/add-provider-name
branch
from
September 18, 2026 11:05
767f88c to
8229f0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes AGE-2286
Changes
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,python/trueforge_sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Medium Risk
Includes database migrations with a new unique constraint and a breaking OpenAPI/SDK response shape (new required
namefield).Overview
Adds a persisted
nameidentity on sandbox provider settings (currently alwaysmanifest.typeon write) and returns it on configured provider GET/PUT responses.Postgres and SQLite migrations add a
namecolumn, backfill from existing manifest JSON, enforce NOT NULL, and add UNIQUE (tenant_id, name). Store upserts and env-synthesized TrueFoundry records setnamefrommanifest.type; the settings PUT body still only accepts the manifest.OpenAPI
ConfiguredSandboxProviderand the regenerated TS/Python SDKs now requirename. Tests and wire mocks were updated accordingly.Reviewed by Cursor Bugbot for commit 8229f0a. Bugbot is set up for automated code reviews on this repo. Configure here.