Skip to content

feat: persist and expose sandbox provider name in settings - #800

Open
thesujai wants to merge 5 commits into
mainfrom
feat/add-provider-name
Open

thesujai wants to merge 5 commits into
mainfrom
feat/add-provider-name

Conversation

@thesujai

@thesujai thesujai commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes AGE-2286

Changes

  • feat: persist and expose sandbox provider name in settings

Checklist

  • I have read the contributing guidelines
  • pnpm build, pnpm test, pnpm typecheck, pnpm lint:ci, and pnpm format:check pass locally
  • Tests added/updated where it makes sense
  • No hand-edits to generated code (packages/trueforge-sdk, python/trueforge_sdk, .github/fern/openapi/openapi.json, docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge
  • Docs / .env.example updated if configuration or behavior changed

Note

Medium Risk
Includes database migrations with a new unique constraint and a breaking OpenAPI/SDK response shape (new required name field).

Overview
Adds a persisted name identity on sandbox provider settings (currently always manifest.type on write) and returns it on configured provider GET/PUT responses.

Postgres and SQLite migrations add a name column, backfill from existing manifest JSON, enforce NOT NULL, and add UNIQUE (tenant_id, name). Store upserts and env-synthesized TrueFoundry records set name from manifest.type; the settings PUT body still only accepts the manifest.

OpenAPI ConfiguredSandboxProvider and the regenerated TS/Python SDKs now require name. Tests and wire mocks were updated accordingly.

Reviewed by Cursor Bugbot for commit 8229f0a. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot

changeset-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8229f0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@truefoundry/trueforge-sdk Patch
@truefoundry/trueforge Patch
@truefoundry/trueforge-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

SET name = manifest ->> 'type'
WHERE name IS NULL
`.execute(db);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenant_id and name will be a unique constraint

@thesujai
thesujai force-pushed the feat/add-provider-name branch from 767f88c to 8229f0a Compare September 18, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant