chore: Enhance attachment ui - #802
Open
harshil-2096 wants to merge 2 commits into
Open
harshil-2096 wants to merge 2 commits into
harshil-2096 wants to merge 2 commits into
Conversation
harshil-2096
requested review from
govindavashishtha,
kumarsks619,
qaifi-tf,
sajal-truefoundry,
sayan-truefoundry and
vinit-truefoundry
as code owners
September 18, 2026 07:53
🦋 Changeset detectedLatest commit: 27bfe95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f66e7ed. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #
Changes
How was this tested?
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,python/trueforge_sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Low Risk
Presentation-only changes to attachment chips and layout; no changes to upload, storage, or auth flows.
Overview
Composer and sent-message non-image attachments now render as horizontal chips with extension-based icons, a visible truncated filename, and formatted size (KB/MB) instead of a small square thumbnail with only a tooltip.
AttachmentCardgains optionalsizeBytes,getAttachmentFileIconName(pdf/doc/csv/json/etc.), and keeps the compact image thumbnail when a preview URL exists.AttachmentsContainerderives byte size from the stagedFileor from base64 data URIs on sent attachments. Layout tweaks: composer attachment row scrolls horizontally when many files are staged; sent attachment rows can wrap.New Lucide-backed icon keys (
file-text,file-spreadsheet,file-code) are registered for the chip UI. Tests cover icon mapping, metadata display, and container behavior.Reviewed by Cursor Bugbot for commit 27bfe95. Bugbot is set up for automated code reviews on this repo. Configure here.