feat: Turn ownership during writes - #806
Open
sr07asthana wants to merge 8 commits into
Open
sr07asthana wants to merge 8 commits into
sr07asthana wants to merge 8 commits into
Conversation
sr07asthana
requested review from
bhaveshpatel640,
chiragjn,
debajyoti-truefoundry,
heerambavi1998 and
thesujai
as code owners
September 18, 2026 09:36
🦋 Changeset detectedLatest commit: 708cc7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #
Changes
How was this tested?
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,python/trueforge_sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Medium Risk
Touches core session-store write paths and multi-replica turn execution; wrong caller updates are now rejected, but any code still calling progress APIs without the new field will fail at compile/runtime.
Overview
Running-turn progress mutations now require
expected_active_executor_idto match the turn’sactive_executor_id, so only the owning replica can append events, update snapshots, or finish the turn.TurnHandlecentralizes this viaturnWriteScope()on every store write during execution.Cancel/freeze (
freezeAndGetTurn) is unchanged and stays unfenced, so another node can still stop a turn when the owner is gone. A stale or wrong replica getsTurnExecutorMismatchErrorinstead of corrupting state.The contract spans
ISessionStore, in-memory, Postgres, and SQLite (progress fences renamed from “running only” to running + owner), with contract tests and a patch changeset for core/trueforge.Reviewed by Cursor Bugbot for commit 708cc7c. Bugbot is set up for automated code reviews on this repo. Configure here.