Layout/mode chrome parity and default withRouter on - #811
govindavashishtha wants to merge 1 commit into
Conversation
Drawer/dock/widget get Agents/Sessions/Schedules nav like sidebar, with compact session stacking and AgentLibrary landing on the library; withRouter now defaults to true so hosts get URL sync unless they opt out. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: 9e26262 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9e26262. Configure here.
| shell?.setLibraryOpen(false); | ||
| shell?.setSchedulesOpen(false); | ||
| }} | ||
| onClick={handleBackToChat} |
There was a problem hiding this comment.
Library back returns empty state
Medium Severity
AgentLibrary now lands on the Agents overlay, but Back to chat only closes that overlay. In this mode the shell is idle and New Chat is disabled, so the control on the default screen drops users onto SelectAgentEmptyState — the empty landing this change set out to remove.
Reviewed by Cursor Bugbot for commit 9e26262. Configure here.
| }} | ||
| /> | ||
| </aside> | ||
| ) : null} |
There was a problem hiding this comment.
Mobile drawer recents squeeze thread
Medium Severity
Drawer Recents is a fixed w-64 column that stays in the row on small screens and starts open. Sidebar hides the same pane below md. On a phone the thread is left with a sliver of width until the user happens to collapse Recents or open a history item.
Reviewed by Cursor Bugbot for commit 9e26262. Configure here.
|
|
||
| useEffect(() => { | ||
| if (!recentsAllowed) setRecentsOpen(false); | ||
| }, [recentsAllowed]); |
There was a problem hiding this comment.
Recents stay closed after overlay
Medium Severity
The Recents effect writes recentsOpen to false whenever an overlay or builder makes Recents disallowed. showRecentsPane already hides the pane in those cases, so the write is unnecessary and the panel does not come back after Back to chat even if the user never collapsed it.
Reviewed by Cursor Bugbot for commit 9e26262. Configure here.
1 participant
Summary
TrueForgeUIwithRoutertotrue; hosts that must not own the URL can passwithRouter={false}.Test plan
withRouter={false}leaves path sync offpnpm --filter @truefoundry/trueforge-ui testMade with Cursor