Revert "Persist shell navigation in sessionStorage when withRouter is off" - #831
Merged
govindavashishtha merged 1 commit intoSep 21, 2026
Conversation
… off. (#…" This reverts commit c37b822.
govindavashishtha
requested review from
kumarsks619,
qaifi-tf,
sajal-truefoundry,
sayan-truefoundry and
vinit-truefoundry
as code owners
September 21, 2026 13:12
|
govindavashishtha
enabled auto-merge (squash)
September 21, 2026 13:13
haripriya1909
approved these changes
Sep 21, 2026
govindavashishtha
deleted the
revert-813-feat/shell-storage-routing-without-router
branch
September 21, 2026 13:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #813
Note
Medium Risk
Removes navigation persistence and URL isolation for default (non-router) embeds, which may regress reload/share behavior hosts relied on after #813.
Overview
Reverts the sessionStorage-backed shell location feature (#813). When
withRouteris false (the default for embeds), shell navigation no longer persists paths and query state insessionStorageor keeps the host URL clean while mirroring routes internally.Runtime: Removes
ShellLocationProvider,shellLocationStore,ShellStorageRouteSync, and the sharedShellRouteSyncCorewrapper.ShellRouteSyncagain owns the full react-router bidirectional sync when routes are resolved; withoutwithRouter, there is no route sync bridge andRemoteIdRouteBridgeis not wired. Share/session query helpers (useSessionShareSearch, closing sessions) go back towindow.locationviareplaceSessionShareSearchinstead of the location store.Boot / share links:
LibrarySessionShareBootalways reads share params from the real URL on mount (no “consume into storage then strip” flow).Docs: README drops
withRouter/routesfrom the props table; customization docs no longer describetfy-aui-shell-locationor storage-vs-URL behavior.Tests: Deletes
ShellStorageRouteSynccoverage and storage cleanup hooks from container/shell-mode tests.Reviewed by Cursor Bugbot for commit 8a82105. Bugbot is set up for automated code reviews on this repo. Configure here.