Skip to content

Revert "Persist shell navigation in sessionStorage when withRouter is off" - #831

Merged
govindavashishtha merged 1 commit into
mainfrom
revert-813-feat/shell-storage-routing-without-router
Sep 21, 2026
Merged

govindavashishtha merged 1 commit into
mainfrom
revert-813-feat/shell-storage-routing-without-router

Conversation

@govindavashishtha

@govindavashishtha govindavashishtha commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Reverts #813


Note

Medium Risk
Removes navigation persistence and URL isolation for default (non-router) embeds, which may regress reload/share behavior hosts relied on after #813.

Overview
Reverts the sessionStorage-backed shell location feature (#813). When withRouter is false (the default for embeds), shell navigation no longer persists paths and query state in sessionStorage or keeps the host URL clean while mirroring routes internally.

Runtime: Removes ShellLocationProvider, shellLocationStore, ShellStorageRouteSync, and the shared ShellRouteSyncCore wrapper. ShellRouteSync again owns the full react-router bidirectional sync when routes are resolved; without withRouter, there is no route sync bridge and RemoteIdRouteBridge is not wired. Share/session query helpers (useSessionShareSearch, closing sessions) go back to window.location via replaceSessionShareSearch instead of the location store.

Boot / share links: LibrarySessionShareBoot always reads share params from the real URL on mount (no “consume into storage then strip” flow).

Docs: README drops withRouter / routes from the props table; customization docs no longer describe tfy-aui-shell-location or storage-vs-URL behavior.

Tests: Deletes ShellStorageRouteSync coverage and storage cleanup hooks from container/shell-mode tests.

Reviewed by Cursor Bugbot for commit 8a82105. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot

changeset-bot Bot commented Sep 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8a82105

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@govindavashishtha
govindavashishtha enabled auto-merge (squash) September 21, 2026 13:13
@govindavashishtha
govindavashishtha merged commit 079bd41 into main Sep 21, 2026
9 checks passed
@govindavashishtha
govindavashishtha deleted the revert-813-feat/shell-storage-routing-without-router branch September 21, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants