Cleanup and release v0.6.0-rc.5#88
Merged
Merged
Conversation
Renaming cbor-smol to serde is confusing and the re-export is not necessary as the cbor-smol version is an implementation detail. Fixes: #69
The type is only used internally and does not have to be part of the public API.
The relevant types are already re-exported directly so we don’t have to re-export the entire crate.
We already validate the algorithm so we can also just use an enum instead of a struct. Fixes: #62
The authenticator module contains the main types of the crate so it makes sense to provide them from the top level instead of the authenticator module.
0x0ece
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains various cleanups for the v0.6.0 release and releases v0.6.0-rc.5 with the changes:
repr(u8)forctap2::Errorand implementFrom<ctap2::Error>foru8, fixes ImplementFrom<ctap2::Error> for u8#63Subcommandenum forauthenticator_config_commands, fixes get_info: Change authenticator_config_commands to use enum #85KnownPublicKeyCredentialParametersan enum, fixes Consider using an enum for KnownPublicKeyCredentialParameters #62