feat: add atomic-polyfill to support more targets#12
Closed
elpiel wants to merge 3 commits intotrussed-dev:mainfrom
Closed
feat: add atomic-polyfill to support more targets#12elpiel wants to merge 3 commits intotrussed-dev:mainfrom
atomic-polyfill to support more targets#12elpiel wants to merge 3 commits intotrussed-dev:mainfrom
Conversation
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
nickray
reviewed
Mar 17, 2023
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
atomic-polyfill to support more targets
|
What is needed to get this PR merged? |
Author
|
@avsaase you could as in the Matrix channel |
|
Is this going to be merged? |
Author
|
I don't think there are any maintainers anymore. |
Member
|
I’m reluctant to pull in an additional dependency unconditionally but I think it should be fine to have a feature flag that replaces |
Contributor
|
Adding |
Member
|
Closing in favor of #25. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9
CI builds for those targets can also be added and mentioned in README.
critical-section implementation is also required.