Repository navigation
test: give monitor wake assertions more time on Windows runners - #161
Merged
Merged
Conversation
The delayed onDone completion test failed on windows-latest (run 39860949158): spawning a shell plus 'sleep 1' outlasted the fixed 5s waitFor. Use a 12s bound on Windows and size the test timeouts from it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
onDone delayed completion preserves the custom wake outcometest failed onwindows-latestin run 39860949158: the monitor's shell spawn plussleep 1took longer than the fixed 5 swaitForinexpectIdleMonitorWake(the test ran 7.2 s).MONITOR_WAKE_TIMEOUT_MSis 12 s on Windows and stays 5 s elsewhere.No production code changes.