Pre-stable hardening: auth, vhost TLS, path handling, DNS, plugin startup#34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-stable hardening pass. Fixes a set of correctness, security and robustness issues found while reviewing the project before tagging it stable.
Security
go/path-injectionfindings onapi/sites.go,config.go,logs_explorer.goandphp.go./docker/container listing is gated per site on the plugin being enabled.Correctness / robustness
restartre-execsstart(not itself) after the old process has actually exited;stoppolls for exit instead ofWaiton a non-child.restartnow cover HTTP/3 and DNS servers, not just the last HTTP server.ResponseHeaderTimeoutto mitigate slowloris and hung upstreams.Verification
go build ./...(+web_only/dns_onlytags),go vet,gofmt: clean.go test -race ./...: all green (added tests for domain/path validation and DNS zone boundary).govulncheck ./...: 0 vulnerabilities.