v1 readiness: correctness fixes, edge hardening, auto-TLS, load balancing, ops#35
Merged
Conversation
…uts and stop writer leak
…aders, HSTS, force-https and cache-control
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings GoUp to a credible v1.0: closes the remaining correctness bugs, adds the edge/TLS/ops features a public web server is expected to have, and hardens CI, validation, and docs. Every change was built, vetted, race-tested, and the load-bearing ones were exercised end-to-end.
Correctness fixes
PluginManager.ExitPlugins()instead of being orphaned holding their ports.If-None-Matchis normalised). Verified: revalidation now returns 304.Logger.Writer()(direct line-buffered writer, no pipe/goroutine per spawned process).LoadAllConfigsno longer loadsconf.global.jsonas a phantom site; DockerStandard only pulls/builds when enabled.api_bind,dashboard_bind).New capabilities
ssl.acme).proxy_upstreams). Verified: round-robin + failover on a killed backend with no 502.Cache-Control.SIGHUP(andsystemctl reload); log retention purge.goup version/--versionwith release-injected build metadata.Config, CI, ops, docs
goup validatenow does real semantic validation: rejects unknown JSON fields, checks cert/root paths, port ranges, and cross-site conflicts (duplicate domains, SSL/non-SSL port mix). SharedSiteConfig.Validate()used by the CLI and the API. Verified end-to-end.init/goup.service), Dockerfile,.dockerignore, and a production deployment guide (docs/production.md).CHANGELOG.mdadded.Verification
go build ./...(+web_only/dns_only),go vet,gofmt: clean.go test -race ./...: all green.staticcheck: only two pre-existing SA6002 (thehttputil.BufferPoolinterface requires[]bytepools).govulncheck ./...: 0 vulnerabilities.Not verified in this environment