Repository navigation
Allow script speech during media playback and prioritize speech hooks - #148
Merged
trypsynth merged 2 commits intoOct 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Script speech can be silently dropped while media is playing. Speech-rewriting hooks can also miss their 30 ms deadline behind queued script callbacks, while a timed-out hook can continue running with a separate 250 ms budget.
This fixes both paths:
backtalk.speak, allowing queued and interrupting requests during playback while retaining existing speech permissions and mute, recording, recognition, and call policies.The deadline is unchanged, and hooks cannot interrupt a task already running. Update the scripting guide and differences documentation, and add eight regression tests for queue ordering, timeout cleanup, same-thread reentry, and shared deadlines.
Follow-up to #62. The media-playback and timing changes are in separate commits.
Validation:
git diff --checkpassed.:lintPhoneDebugwas run and failed with 153MissingTranslationerrors instrings.xml,strings_gemini_api_key.xml, andstrings_scripts.xml. These resource files are unchanged by this PR; no new UI strings or lint-baseline changes are included.